Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... 📒 Files selected for processing (12)
✏️ Tip: You can disable in-progress messages and the fortune message in your review settings. Tip CodeRabbit can enforce grammar and style rules using `languagetool`.Configure the 📝 WalkthroughWalkthroughThis PR refactors the organization and project management UI by consolidating page-level logic into centralized page components, converting modals from route-driven to prop-driven, and removing embedded UI implementations. Several route handlers and inline components are deleted in favor of delegated page components that handle rendering and state. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rohanchkrabrty
added
the
Do not merge
paanSinghCoder
approved these changes
Mar 2, 2026
Contributor
paanSinghCoder
left a comment
paanSinghCoder
left a comment
There was a problem hiding this comment.
Please check page - view renaming
Pull Request Test Coverage Report for Build 22562400528Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Merged
rohanchkrabrty
removed
the
Do not merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate SDK plans page from router-coupled components to standalone view components, converting the confirm-plan-change modal from route-based to state-based.
Changes
react/views/plans/ConfirmPlanChangefrom a route-based component (useParams/useNavigate) to a state-basedConfirmPlanChangeDialogwithopen/onOpenChange/planIdpropsuseNavigateinPlanPricingColumnwithonConfirmPlanChangecallback prop<Outlet />from the plans page — dialog now renders inline with state management/plans/confirm-change/$planIdsub-route fromroutes.tsxcomponents/organization/plans/index.tsxwith thin wrapper that renders<PlansPage />Technical Details
@tanstack/react-routerimports — all routing isolated in thin wrapper{ open, planId }following established patternonConfirmPlanChangecallback threads fromPlansPage→PlansList→PlanPricingColumnhelpers.test.ts) moved alongside helpers to views directory